Re: [PATCH 2.6.18 ] LIB Add gen_pool_destroy().

[Steve Wise <swise@opengridcomputing.com>]

> > index 71338b4..c8afa10 100644
> > --- a/lib/genalloc.c
> > +++ b/lib/genalloc.c
> > @@ -36,6 +36,28 @@ EXPORT_SYMBOL(gen_pool_create);
> >  
> >  
> >  /*
> > + * Destroy a memory pool.  Assumes the user deals with releasing the
> > + * actual memory managed by the pool.  
> > + *
> > + * @pool: pool to destroy.
> > + *
> > + */
> 
> Please use kernel-doc for exported kernel interfaces.
> See Documentation/kernel-doc-nano-HOWTO.txt for info,
> and/or see some file like kernel/printk.c for examples.
> 
> > +void gen_pool_destroy(struct gen_pool *pool)
> > +{
> > +	struct list_head *_chunk, *next;
> > +	struct gen_pool_chunk *chunk;
> > +
> > +	list_for_each_safe(_chunk, next, &pool->chunks) {
> > +		chunk = list_entry(_chunk, struct gen_pool_chunk, next_chunk);
> > +		kfree(chunk);
> > +	}
> > +	kfree(pool);
> > +	return;
> > +}
> > +EXPORT_SYMBOL(gen_pool_destroy);
> > +
> > +
> > +/*
> >   * Add a new chunk of memory to the specified pool.
> >   *
> >   * @pool: pool to add new memory chunk to
> > -
> 
> argh.  more.  (not part of your patch)


I formatted it to align with the rest of the file...

Steve.