mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: sylvain.meyer@worldonline.fr
Subject: [Patch] Remove unnecessary check in drivers/video/intelfb/intelfbhw.c
Date: Thu, 28 Sep 2006 00:46:14 +0200	[thread overview]
Message-ID: <1159397174.14069.2.camel@alice> (raw)

hi,

all callers and the function itself dereference dinfo,
so we can remove the check. (coverity id #1371)

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.18-git7/drivers/video/intelfb/intelfbhw.c.orig	2006-09-27 21:47:46.000000000 +0200
+++ linux-2.6.18-git7/drivers/video/intelfb/intelfbhw.c	2006-09-27 21:48:04.000000000 +0200
@@ -648,7 +648,7 @@ intelfbhw_print_hw_state(struct intelfb_
 	int index = dinfo->pll_index;
 	DBG_MSG("intelfbhw_print_hw_state\n");
 
-	if (!hw || !dinfo)
+	if (!hw)
 		return;
 	/* Read in as much of the HW state as possible. */
 	printk("hw state dump start\n");



                 reply	other threads:[~2006-09-27 22:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1159397174.14069.2.camel@alice \
    --to=snakebyte@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sylvain.meyer@worldonline.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®