From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbcKZOsq (ORCPT ); Sat, 26 Nov 2016 09:48:46 -0500 Received: from forward19p.cmail.yandex.net ([77.88.31.22]:33438 "EHLO forward19p.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbcKZOsj (ORCPT ); Sat, 26 Nov 2016 09:48:39 -0500 X-Greylist: delayed 657 seconds by postgrey-1.27 at vger.kernel.org; Sat, 26 Nov 2016 09:48:38 EST Authentication-Results: mxback5g.mail.yandex.net; dkim=pass header.i=@yandex.com.tr From: Ozgur Karatas Envelope-From: mueddib@yandex.com.tr To: idryomov , sage , linux-kernel In-Reply-To: <8504411480170970@web28m.yandex.ru> Subject: Re: [PATCH] Fixed a functions to rbd.c MIME-Version: 1.0 Message-Id: <11594991480171053@web8g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sat, 26 Nov 2016 16:37:33 +0200 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello all, I fixed to checkpatch.pl error and fixed two errors. static char* obj_op_name(enum obj_operation_type op_type) static bool single_major = false; Signed-off-by: Ozgur Karatas ---  drivers/block/rbd.c --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2,7 +2,6 @@  /*     rbd.c -- Export ceph rados objects as a Linux block device -     based on drivers/block/osdblk.c:     Copyright 2009 Red Hat, Inc. @@ -24,7 +23,7 @@     For usage instructions, please refer to: - Documentation/ABI/testing/sysfs-bus-rbd + Documentation/ABI/testing/sysfs-bus-rbd   */ @@ -449,7 +448,7 @@ static struct workqueue_struct *rbd_wq;   * Default to false for now, as single-major requires >= 0.75 version of   * userspace rbd utility.   */ -static bool single_major = false; +static bool single_major;  module_param(single_major, bool, S_IRUGO);  MODULE_PARM_DESC(single_major, "Use a single major number for all rbd devices (default: false)"); @@ -866,7 +865,7 @@ static int parse_rbd_opts_token(char *c, void *private)          return 0;  } -static char* obj_op_name(enum obj_operation_type op_type) +static char *obj_op_name(enum obj_operation_type op_type)  {          switch (op_type) {          case OBJ_OP_READ: @@ -5587,15 +5586,14 @@ static int rbd_dev_header_info(struct rbd_device *rbd_dev)   */  static inline size_t next_token(const char **buf)  { - /* - * These are the characters that produce nonzero for - * isspace() in the "C" and "POSIX" locales. - */ - const char *spaces = " \f\n\r\t\v"; - - *buf += strspn(*buf, spaces); /* Find start of token */ +/* + * These are the characters that produce nonzero for + * isspace() in the "C" and "POSIX" locales. +*/ - return strcspn(*buf, spaces); /* Return token length */ +const char *spaces = " \f\n\r\t\v"; +*buf += strspn(*buf, spaces); /* Find start of token */ +return strcspn(*buf, spaces); /* Return token length */