From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: reiserfs-dev@namesys.com
Subject: [Patch] Remove unnecessary check in fs/reiserfs/inode.c
Date: Sun, 01 Oct 2006 22:41:57 +0200 [thread overview]
Message-ID: <1159735317.11887.10.camel@alice> (raw)
hi,
since all callers dereference dir, we dont need this check.
Coverity id #337.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.18-git16/fs/reiserfs/inode.c.orig 2006-10-01 22:40:24.000000000 +0200
+++ linux-2.6.18-git16/fs/reiserfs/inode.c 2006-10-01 22:40:35.000000000 +0200
@@ -1780,7 +1780,7 @@ int reiserfs_new_inode(struct reiserfs_t
err = -EDQUOT;
goto out_end_trans;
}
- if (!dir || !dir->i_nlink) {
+ if (!dir->i_nlink) {
err = -EPERM;
goto out_bad_inode;
}
reply other threads:[~2006-10-01 20:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159735317.11887.10.camel@alice \
--to=snakebyte@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®