Re: another attempt to kill off linux/config.h

[Arjan van de Ven <arjan@infradead.org>]

On Wed, 2006-10-04 at 13:24 +0200, Sam Ravnborg wrote:
> On Wed, Oct 04, 2006 at 03:44:34AM -0400, Dave Jones wrote:
> > Every time I (or someone else) gets a patch included
> > removing explicit includes of linux/config.h, another few creep
> > into the tree a day or so later.
> > 
> > Lets kill them all for good.
> > 
> > master.kernel.org:/pub/scm/linux/kernel/git/davej/configh.git
> > 
> > is a git tree killing off all the current users in tree,
> > and adds a #warn to include/linux/config.h that it's going away.
> > (This should still leave as-yet-unmerged trees compiling,
> >  and hopefully get them fixed before they get merged)
> > We can then remove the file for real just before 2.6.19
> 
> Removing it for real will be a pain for external modules.
> They could of course detect that it is missing and then
> drop it.
> I would suggest to keep the #warning in 2.6.19 and only
> remove it for real for 2.6.20.

they'll have to change anyway; delaying it one release doesn't actually
change that. And you can bet on most modules ignoring the warning anyway
and wait until the thing really is gone... making the value that this
extra delay has basically zero. While the cost is that more false users
will sneak into the kernel ;(

Maybe Fedora can ship with an #error here early on; an #error at least
can provide a helpful message on how to fix it.