From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932424AbWJDNbm (ORCPT ); Wed, 4 Oct 2006 09:31:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932427AbWJDNbm (ORCPT ); Wed, 4 Oct 2006 09:31:42 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:49031 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932424AbWJDNbl (ORCPT ); Wed, 4 Oct 2006 09:31:41 -0400 Subject: Re: [PATCH] fs/jffs2: kill warning RE debug-only variables From: David Woodhouse To: Jeff Garzik Cc: Andrew Morton , LKML In-Reply-To: <20061004115718.GA22386@havoc.gtf.org> References: <20061004115718.GA22386@havoc.gtf.org> Content-Type: text/plain; charset=UTF-8 Date: Wed, 04 Oct 2006 14:31:28 +0100 Message-Id: <1159968688.20586.18.camel@pmac.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.0 (2.8.0-7.fc6.dwmw2.1) Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2006-10-04 at 07:57 -0400, Jeff Garzik wrote: > build: > > fs/jffs2/xattr.c: In function ‘unrefer_xattr_datum’: > fs/jffs2/xattr.c:402: warning: unused variable ‘version’ > fs/jffs2/xattr.c:402: warning: unused variable ‘xid’ > > Given that these variables are only used in the debug printk, and they > merely remove a deref, we can easily kill the warning by adding the > derefs to the debug printk. > > Signed-off-by: Jeff Garzik Applied; thanks. -- dwmw2