From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753824AbdKQLZ6 (ORCPT ); Fri, 17 Nov 2017 06:25:58 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33352 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753778AbdKQLZu (ORCPT ); Fri, 17 Nov 2017 06:25:50 -0500 X-Google-Smtp-Source: AGs4zMboWKOWTjMRk/UuiToQ2HUr5RnqB51Z4PZZaz4LB3Sgul6VmtIIWwtsHtOSZnB2ByqVkk2w+A== From: Arvind Yadav To: kishon@ti.com, tony@atomide.com, robh@kernel.org, dan.carpenter@oracle.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2] phy: cpcap-usb: Fix platform_get_irq_byname's error checking. Date: Fri, 17 Nov 2017 16:55:35 +0530 Message-Id: <115b1328cd921849e8a3dd1832c21a3de59aa0e0.1510917723.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The platform_get_irq_byname() function returns negative if an error occurs. zero or positive number on success. platform_get_irq_byname() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v1 : Patch description was not correct. drivers/phy/motorola/phy-cpcap-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c index accaaac..6601ad0 100644 --- a/drivers/phy/motorola/phy-cpcap-usb.c +++ b/drivers/phy/motorola/phy-cpcap-usb.c @@ -310,7 +310,7 @@ static int cpcap_usb_init_irq(struct platform_device *pdev, int irq, error; irq = platform_get_irq_byname(pdev, name); - if (!irq) + if (irq < 0) return -ENODEV; error = devm_request_threaded_irq(ddata->dev, irq, NULL, -- 2.7.4