From: Thomas Gleixner <tglx@linutronix.de>
To: akpm@osdl.org
Cc: dwalker@mvista.com, johnstul@us.ibm.com, mingo@elte.hu,
zippel@linux-m68k.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: + clocksource-initialize-list-value.patch added to -mm tree
Date: Sun, 08 Oct 2006 11:50:39 +0200 [thread overview]
Message-ID: <1160301039.22911.22.camel@localhost.localdomain> (raw)
In-Reply-To: <200610070153.k971rsDf020869@shell0.pdx.osdl.net>
On Fri, 2006-10-06 at 18:53 -0700, akpm@osdl.org wrote:
> A change to clocksource initialization. It's optional for new clocksources,
> but prefered. If the list field is initialized it allows clocksource_register
> to complete faster since it doesn't have the scan the list of clocks doing
> strcmp on each.
Either make it required or not.
> diff -puN arch/i386/kernel/hpet.c~clocksource-initialize-list-value arch/i386/kernel/hpet.c
> --- a/arch/i386/kernel/hpet.c~clocksource-initialize-list-value
> +++ a/arch/i386/kernel/hpet.c
> @@ -27,6 +27,7 @@ static struct clocksource clocksource_hp
> .mult = 0, /* set below */
> .shift = HPET_SHIFT,
> .is_continuous = 1,
> + .list = CLOCKSOURCE_LIST_INIT(clocksource_hpet.list),
...
> +/* Abstracted list initialization */
> +#define CLOCKSOURCE_LIST_INIT(x) LIST_HEAD_INIT(x)
> +
Please use LIST_HEAD_INIT(). This is not an abstraction, this is an
obfuscation.
tglx
next parent reply other threads:[~2006-10-08 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610070153.k971rsDf020869@shell0.pdx.osdl.net>
2006-10-08 9:50 ` Thomas Gleixner [this message]
2006-10-08 14:42 ` Daniel Walker
2006-10-08 15:07 ` Arjan van de Ven
2006-10-08 15:13 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160301039.22911.22.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®