From: Thomas Gleixner <tglx@linutronix.de>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@osdl.org, johnstul@us.ibm.com, mingo@elte.hu,
zippel@linux-m68k.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: + clocksource-add-generic-sched_clock.patch added to -mm tree
Date: Sun, 08 Oct 2006 16:51:52 +0200 [thread overview]
Message-ID: <1160319112.5686.8.camel@localhost.localdomain> (raw)
In-Reply-To: <1160318750.3693.12.camel@c-67-180-230-165.hsd1.ca.comcast.net>
On Sun, 2006-10-08 at 07:45 -0700, Daniel Walker wrote:
> On Sun, 2006-10-08 at 11:55 +0200, Thomas Gleixner wrote:
> > On Fri, 2006-10-06 at 18:53 -0700, akpm@osdl.org wrote:
> > > Adds a generic sched_clock, along with a boot time override for the scheduler
> > > clocksource (sched_clocksource). Hopefully the config option would eventually
> > > be removed.
> >
> > Again, this belongs into the clocksource code and not into sched.c
> >
> > Your patch series scatters clock source related code snippets all over
> > the place. This becomes simply a maintenance nightmare.
>
> It's an API, it's suppose to be used in different places.
Err. clocksource is an API and it is supposed to be at a place, where
clocksource code is.
sched_clock is a user of the clocksource API and there is absolutely no
reason to put that into sched.c
tglx
next prev parent reply other threads:[~2006-10-08 15:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610070153.k971ruEZ020872@shell0.pdx.osdl.net>
2006-10-08 9:55 ` Thomas Gleixner
2006-10-08 14:45 ` Daniel Walker
2006-10-08 14:51 ` Thomas Gleixner [this message]
2006-10-08 15:32 ` Daniel Walker
2006-10-08 15:46 ` Thomas Gleixner
2006-10-08 16:06 ` Daniel Walker
2006-10-08 16:19 ` Thomas Gleixner
2006-10-08 16:27 ` Daniel Walker
2006-10-08 16:54 ` Thomas Gleixner
2006-10-08 17:26 ` Daniel Walker
2006-10-08 18:45 ` Thomas Gleixner
2006-10-08 21:15 ` Daniel Walker
2006-10-08 21:21 ` Thomas Gleixner
2006-10-08 21:33 ` Daniel Walker
2006-10-08 21:41 ` Thomas Gleixner
2006-10-08 22:08 ` Daniel Walker
2006-10-08 22:35 ` Thomas Gleixner
2006-10-08 23:01 ` Daniel Walker
2006-10-09 8:09 ` Thomas Gleixner
2006-10-08 18:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160319112.5686.8.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®