From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: "Tom Long Nguyen (tom.l.nguyen"@intel.com
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: [PATCH] Fix pcie portdrv build without CONFIG_PM
Date: Tue, 10 Oct 2006 13:49:47 +1000 [thread overview]
Message-ID: <1160452187.32237.90.camel@localhost.localdomain> (raw)
The new error handling code uses pcie_portdrv_restore_config() outside
of CONFIG_PM so this function must be moved outside of the #ifdef or it
will get a link error if CONFIG_PM is not set.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Index: linux-cell/drivers/pci/pcie/portdrv_pci.c
===================================================================
--- linux-cell.orig/drivers/pci/pcie/portdrv_pci.c 2006-10-06 13:48:12.000000000 +1000
+++ linux-cell/drivers/pci/pcie/portdrv_pci.c 2006-10-10 13:46:43.000000000 +1000
@@ -37,7 +37,6 @@ static int pcie_portdrv_save_config(stru
return pci_save_state(dev);
}
-#ifdef CONFIG_PM
static int pcie_portdrv_restore_config(struct pci_dev *dev)
{
int retval;
@@ -50,6 +49,7 @@ static int pcie_portdrv_restore_config(s
return 0;
}
+#ifdef CONFIG_PM
static int pcie_portdrv_suspend(struct pci_dev *dev, pm_message_t state)
{
int ret = pcie_port_device_suspend(dev, state);
reply other threads:[~2006-10-10 3:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160452187.32237.90.camel@localhost.localdomain \
--to=benh@au1.ibm.com \
--cc="Tom Long Nguyen (tom.l.nguyen"@intel.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®