From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: driver,platform,firmware,system, data data data ....
Date: Tue, 10 Oct 2006 15:57:00 +1000 [thread overview]
Message-ID: <1160459820.32237.112.camel@localhost.localdomain> (raw)
In-Reply-To: <452B3417.7050106@keyaccess.nl>
On Tue, 2006-10-10 at 07:48 +0200, Rene Herman wrote:
> Benjamin Herrenschmidt wrote:
>
> [ device->platform_data ]
>
> > So except for the size of the patch and boredom of going through all
> > of them fixing them, do you see any reason why this later one
> > shouldn't be moved out to platform_driver ? (I haven't actually
> > checked at all the occurences in the tree though).
>
> You'll find it being used in drivers/base/isa.c for one. I only used it
> there because it was available and made for slightly nicer code though.
> If platform_data is going away (and assuming you wouldn't want similar
> abuse of your new system_data) it wouldn't be a problem to move the
> driver pointer to the private struct isa_dev as in the attached.
Ah thanks, I missed that use.
Well, we'll see what Greg has to say but thanks for the patch.
Cheers,
Ben.
prev parent reply other threads:[~2006-10-10 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 3:36 Benjamin Herrenschmidt
2006-10-10 5:48 ` Rene Herman
2006-10-10 5:57 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160459820.32237.112.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®