From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: markus.lidel@shadowconnect.com, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] I2O: more error checking
Date: Thu, 12 Oct 2006 00:06:28 +0100 [thread overview]
Message-ID: <1160607988.19068.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20061011214148.GA20524@havoc.gtf.org>
Ar Mer, 2006-10-11 am 17:41 -0400, ysgrifennodd Jeff Garzik:
> i2o_scsi: handle sysfs failure
>
> i2o_device:
> * convert i2o_device_add() to return integer error code
NAK, Fix the comments to match the code changes.
> diff --git a/drivers/message/i2o/device.c b/drivers/message/i2o/device.c
> index ee18305..5f2c317 100644
> --- a/drivers/message/i2o/device.c
> +++ b/drivers/message/i2o/device.c
> @@ -217,15 +217,15 @@ static struct i2o_device *i2o_device_all
> * Returns a pointer to the I2O device on success or negative error code
> * on failure.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> */
> -static struct i2o_device *i2o_device_add(struct i2o_controller *c,
> - i2o_lct_entry * entry)
> +static int i2o_device_add(struct i2o_controller *c, i2o_lct_entry *entry)
> {
Otherwise Ack.
prev parent reply other threads:[~2006-10-11 22:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 21:41 Jeff Garzik
2006-10-11 23:06 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160607988.19068.7.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.lidel@shadowconnect.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®