From: Arjan van de Ven <arjan@infradead.org>
To: Amol Lad <amol@verismonetworks.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
kernel Janitors <kernel-janitors@lists.osdl.org>
Subject: Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
Date: Fri, 13 Oct 2006 13:56:12 +0200 [thread overview]
Message-ID: <1160740572.3000.489.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <1160739628.19143.376.camel@amol.verismonetworks.com>
On Fri, 2006-10-13 at 17:10 +0530, Amol Lad wrote:
> Removed save_flags()/cli()/sti() and used (light weight) spin locks
Hi,
I applaud removing such legacy-should-be-dead-by-now functions; however,
I'm not entirely sure your conversion is correct. While you convert all
places that do cli/sti with locks.... you do not seem to be adding the
locks to the places that the cli/sti pairs protected against (the IRQ
handlers).... so it looks like your conversion is incomplete ;(
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2006-10-13 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 11:40 Amol Lad
2006-10-13 11:56 ` Arjan van de Ven [this message]
2006-10-13 12:36 ` Amol Lad
2006-10-13 15:00 ` Alan Cox
2006-10-14 7:39 ` Amol Lad
2006-10-14 12:18 ` Alan Cox
2006-10-14 14:20 ` Alan Cox
2006-10-14 17:49 ` [KJ] " Matthew Wilcox
2006-10-14 18:41 ` Alan Cox
2006-10-14 18:50 ` Matthew Wilcox
2006-10-16 4:32 ` Amol Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160740572.3000.489.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=amol@verismonetworks.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®