From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BE342C2346 for ; Thu, 14 May 2026 03:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778727724; cv=none; b=fhowhebCLQykWMBlmXbneD+N1by1ihUlu0Ou2P95iydz/wYDPxkGEpw0bYjONVC6uWRQFmf/g5o0mF/G4vHRgCSVhINJrjeskWkpHS7ngLjCVHp37pcgRVf544cyR0ktn8Fr0K12YVC1qLoCKhOdxjcjOpMGsPs/X2DLHcQHZxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778727724; c=relaxed/simple; bh=JlGxCNFP5AqscuOf2R/v0doOmVWZhMUieAQXTabK+Fw=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=jeelPUHGIN636diMo4u8rwnSLNbFysYBda5gJoArkmn5JWaWyPGX61LIVyizrXQkKzrv7fjwrhJ31ugV12k+BgKERBuSddR1VC8rEgu2QOjo5rraviYFdv0JFUpcbTVw9T6HBxsifjd2yAK0EGFRCd7SbnAUY7f8ygYYTllMQH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JEVmWS7v; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FoYY3PLr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JEVmWS7v"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FoYY3PLr" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64E0A2JL3474770 for ; Thu, 14 May 2026 03:02:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nuVaQCgOifhWXgFFXpvwYHL8FLwD6PE1wpppWoTe/so=; b=JEVmWS7vUSZVT0KI K/fr3Ry8MUhdCO6Z77tSjCd6mZGGA2kkkFU6fM/oAOZOvzMiW5OvFiVsL9pDuZq2 OUJFE7pYjIcTLSr8ho6EAfN4g19KJS9gyfcX/LS8U299inTEx1yT0bG+OFFhPBm5 oGFDdzj8z6i65QG1yIpBrco+/S+Wnpv9NDI1T7IYDbWzPeBHUTyuyzkpick/Fi0U SelUx51yNyoza6Ug/mDZvTMmObiel8IQnNpGw1R/VET8JuVQ/xzSKnkb3UTlafMR n8F+KG/Mf8O7xHh0m/qiXfPTaNQuZ9vxiAIcU7xrOQJafl3ax2vuLCicjHncZO6E Fvvgnw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4p41brn9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 14 May 2026 03:02:02 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b9a6d84522so141351535ad.2 for ; Wed, 13 May 2026 20:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778727721; x=1779332521; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nuVaQCgOifhWXgFFXpvwYHL8FLwD6PE1wpppWoTe/so=; b=FoYY3PLrs/N5YMpum2IwCPkGQCvdFWGNtgyCs1SZVawFvKMNc91xYAnFw9MwHurGCQ jvMA81Cc+AmyGsi7+YvoBmUnBXMiHAk5+y6vomQ/dbPFytyE7YDJaZJKvxgtYnW9Bd4G Nz7rNsjK+MaF2G+Y9cM8/EyqWK7XFC0iKvPuaLiz70tAyZqKhCEL1eTWTrUu6nClsgFa EYrCGnbWbJ9Z4Ya8vx6tELASWoaWBd0olUEs976LVaSVnodvg0HjYpd1/yzcobkGlAOA vCTypauZb3qJkLmRnM+CGEXm0nLRd8X0pYG/yi9A1ku00TWLZySdyD0f6GUPVZn2HwSQ /xFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778727721; x=1779332521; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nuVaQCgOifhWXgFFXpvwYHL8FLwD6PE1wpppWoTe/so=; b=bdakpGWayNQVBzyIVry7Wxj9DeP+H5PkeuLOmTHC3fNXJsRyaJJPyY/2sqES3bV8Dy rjPfXychkHFLn2XE3Wbi1Thboc+OxYr/mfaDaWwOo8Dgp4nW265qaIe2knhFdJlrN8IN +tpch7rZdoN/jktxqHQFRAOlwZ7tvNwzS/5iAatjxZRqtSr5QQRVTu/WCusE5kbpn6Xq 7Rrqt1ne5L7ODyYSrWQRnSCfGJ2VRJZyrBtAIFFGbxtPKHCVoD0cbtYpnuxe6MX5nlaY VoBqe1mHIDd336YZ62fZVA6Lde9ny0+1lYSneePveIfE/kaQEEDNOSg0Doen3BoKsIhL rW5Q== X-Forwarded-Encrypted: i=1; AFNElJ+vxL5QSmGtR8IApGZjrqP4r+YK6KpZ8QFRCDh6bZQNrzHLkKKj1pNMCywAPyRggnwVCajP5q/2ZniI2o8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk8+nCqGX+BWciBb+YsAl4ypGSCfGpsqH6h7Ks+hxADYwQ8Rs1 6PDxIW0IUWqtSBmN3SzPEIPtfqS9DQtFxc3g6WlOP6GUvk3FmyeizFSdJGT7aZhKdWrtrO0uDl+ HvdJEOsHmBw9lt3AjEuDdM9OSxHHNH78J/wVr6IxLPGwBSAFZISo5a8CbXugkjilhzUc= X-Gm-Gg: Acq92OGOvV8vI7NasvlAFKYz88zv+7Zl5o7Fr/XWt7T53RcfgK90eORhCZvcoB90kWd Z6DEmhgkmE2sY2ObW7d1XIdLDaENBUUPJ+QLdm4TtlqvBJeRPhT2Lia8oT5lFNpCXkeqN0C2xhO mjp/tO4Xtms8njUD17UI5xEAmqIgf20/7N0EKcGT6yzSkrcVzrR2Wa0J4k+rATzOrybHJQ744jn 98tfF+4Esz5uCp70HnCMmB4feF5wUK0kTrvTx9jGJ0SJre5I87AdP2x1hPAq8C0sES5xMq2kNLV 4IQQrqXmMq4qre1JzQL2DM2p7CYzsIqH9Sq1GsX6KZBRJXMl6L6PQHyIb9Y8Bk1CIi99WDXyZlW ALYehUiz9IS4QVkjd8seRxE77lDsC7PIVHGrG0ynq5rMcga3ddF96+yrFsFXma3vyYF3R8ck2Bs 9b599rZJmN6X3cCvwGkyqVtg/5Uns= X-Received: by 2002:a17:903:31d5:b0:2b4:5cea:f61c with SMTP id d9443c01a7336-2bd2718bf40mr48530895ad.4.1778727720351; Wed, 13 May 2026 20:02:00 -0700 (PDT) X-Received: by 2002:a17:903:31d5:b0:2b4:5cea:f61c with SMTP id d9443c01a7336-2bd2718bf40mr48530515ad.4.1778727719721; Wed, 13 May 2026 20:01:59 -0700 (PDT) Received: from [10.249.28.138] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d11d6easm7082155ad.72.2026.05.13.20.01.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 20:01:59 -0700 (PDT) Message-ID: <1160f00c-2d48-4470-aecd-2420b9c79058@oss.qualcomm.com> Date: Thu, 14 May 2026 11:01:55 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: Re: [PATCH v7 3/6] media: qcom: iris: Add B frames support for encoder To: Dmitry Baryshkov References: <20260512-batch2_features-v7-0-4954e3b4df84@oss.qualcomm.com> <20260512-batch2_features-v7-3-4954e3b4df84@oss.qualcomm.com> Content-Language: en-US From: Wangao Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=df+wG3Xe c=1 sm=1 tr=0 ts=6a053b2a cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=kLwFXv0XdFo9VwVnQ6MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE0MDAyNyBTYWx0ZWRfXyrS/uzjJVyUh bACiQ/c3RSZLe4ImOqczeSzPlrjse1K45fHsrb4IWOHT3ifmIX8IyZsVuY6vuSswXF7IzTRw/Nr 3iSfULl/aMf2xjGsOmMP3mLmbSSVUIJDYRId+gNkqSiuRpk7YtQI0638wJVUfG/fkXoLlflTbca 0+6tihSPYuozj1HKtUXS9Pk0tkGFHRvJmSWyzDxRFh65zO8ckiCBVcisB1haj6vI34saoJ/ozda /qDr0WTrqD4GMRwN205tQs8tmgZwguHqBmMySIf2KV6k/V2LOALOU/z36wrvS2qNC0Qoo9LkgWT s3p6fsoS2R/EtIYpOO96Gg2WbV0k7MwoitFdDQYradhIotoM1sTUDoX7/WT3YLPQOAZSiTvN6QF NXdauepbnr4rbFoUfW7VKbMD3tLi0qPDY1AWz/olFoe9C7q3ffzGL+TBX2abVbm7Ce8gbRS135Y XxkCp8XirUW8pCiREuw== X-Proofpoint-GUID: GqXo1Csa9VhPOYDvgOVUE53R_xUs8zJl X-Proofpoint-ORIG-GUID: GqXo1Csa9VhPOYDvgOVUE53R_xUs8zJl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_04,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605140027 On 2026/5/13 19:00, Dmitry Baryshkov wrote: >> +int iris_set_intra_period(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id) >> +{ >> + const struct iris_hfi_session_ops *hfi_ops = inst->hfi_session_ops; >> + u32 gop_size = inst->fw_caps[GOP_SIZE].value; >> + u32 b_frame = inst->fw_caps[B_FRAME].value; >> + u32 hfi_id = inst->fw_caps[cap_id].hfi_id; >> + struct hfi_intra_period intra_period; >> + >> + if (!gop_size || b_frame >= gop_size) >> + return -EINVAL; > > The same comment. Maybe I misunderstand something, please correct me if > I'm wrong. The definition of the GOP_SIZE capability allows 0 as a valid > value. Here you are declining it. Why? > >> + GOP_SIZE - Value 0: Behavior depends on the firmware implementation.In most cases, the firmware will treat it as an invalid value or fall back to a default value. - Value 1: Explicitly means all I-frames. The gen1 firmware does not support passing GOP size directly — it is determined by the number of P-frames and B-frames between I-frames. If the client passes a value of 0, it will cause the subsequent gop_size - 1 calculation to produce a negative value. -- Best Regards, Wangao