From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: akpm@osdl.org, dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] esb2rom: use hotplug safe interfaces
Date: Mon, 16 Oct 2006 16:32:32 +0100 [thread overview]
Message-ID: <1161012752.24237.79.camel@localhost.localdomain> (raw)
Fairly self explanatory. Keep a reference initially, drop it when we
free up the driver resources.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc1-mm1/drivers/mtd/maps/esb2rom.c linux-2.6.19-rc1-mm1/drivers/mtd/maps/esb2rom.c
--- linux.vanilla-2.6.19-rc1-mm1/drivers/mtd/maps/esb2rom.c 2006-10-13 15:10:06.000000000 +0100
+++ linux-2.6.19-rc1-mm1/drivers/mtd/maps/esb2rom.c 2006-10-14 21:32:12.000000000 +0100
@@ -140,8 +140,8 @@
window->virt = NULL;
window->phys = 0;
window->size = 0;
- window->pdev = NULL;
}
+ pci_dev_put(window->pdev);
}
static int __devinit esb2rom_init_one(struct pci_dev *pdev,
@@ -164,7 +164,7 @@
* Also you can page firmware hubs if an 8MB window isn't enough
* but don't currently handle that case either.
*/
- window->pdev = pdev;
+ window->pdev = pci_dev_get(pdev);
/* RLG: experiment 2. Force the window registers to the widest values */
@@ -418,7 +418,7 @@
pdev = NULL;
for (id = esb2rom_pci_tbl; id->vendor; id++) {
printk(KERN_DEBUG "device id = %x\n", id->device);
- pdev = pci_find_device(id->vendor, id->device, NULL);
+ pdev = pci_get_device(id->vendor, id->device, NULL);
if (pdev) {
printk(KERN_DEBUG "matched device = %x\n", id->device);
break;
@@ -427,6 +427,7 @@
if (pdev) {
printk(KERN_DEBUG "matched device id %x\n", id->device);
retVal = esb2rom_init_one(pdev, &esb2rom_pci_tbl[0]);
+ pci_dev_put(pdev);
printk(KERN_DEBUG "retVal = %d\n", retVal);
return retVal;
}
reply other threads:[~2006-10-16 15:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161012752.24237.79.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®