From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: brking@us.ibm.com, "Darrick J. Wong" <djwong@us.ibm.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexis Bruemmer <alexisb@us.ibm.com>,
Mike Anderson <andmike@us.ibm.com>
Subject: Re: [PATCH] libsas: support NCQ for SATA disks
Date: Tue, 17 Oct 2006 11:35:37 -0500 [thread overview]
Message-ID: <1161102937.3720.11.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <4534BB5B.6080002@garzik.org>
On Tue, 2006-10-17 at 07:15 -0400, Jeff Garzik wrote:
> Brian King wrote:
> > This doesn't look like the right fix for the oops you were seeing. The
> > SAS usage of libata has ap->scsi_host as NULL, which indicates that
> > libata does not own the associated scsi_host. I'm concerned you may
> > have broken some other code path by making this change. I think the correct
> > fix may require removing the dependence of ap->scsi_host from
> > ata_dev_config_ncq.
>
> Yep. I had already mentioned this on IRC.
I understand, but right at the moment, my priority is sorting out the
aic94xx driver so that it works with SATA devices. It has become
apparent that there's some need for a bit of code sorting out in libata
to drive intelligent sas controllers, so we can take a look at bugs in
ata_dev_config_ncq() when someone's time frees up to look into the
libata issues.
James
next prev parent reply other threads:[~2006-10-17 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 23:56 Darrick J. Wong
2006-10-15 17:42 ` James Bottomley
2006-10-15 18:43 ` Darrick J. Wong
2006-10-15 19:42 ` Luben Tuikov
2006-10-16 22:40 ` Brian King
2006-10-17 11:15 ` Jeff Garzik
2006-10-17 16:35 ` James Bottomley [this message]
2006-10-17 22:42 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161102937.3720.11.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=alexisb@us.ibm.com \
--cc=andmike@us.ibm.com \
--cc=brking@us.ibm.com \
--cc=djwong@us.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®