From: Steven Whitehouse <swhiteho@redhat.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: 2.6 patch] fs/gfs2/ops_fstype.c:fill_super_meta(): fix NULL dereference
Date: Thu, 19 Oct 2006 15:09:22 +0100 [thread overview]
Message-ID: <1161266962.27980.146.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <20061019132659.GO3502@stusta.de>
Hi,
... and this one is pushed to the GFS2 git tree too. Thanks for the
patches,
Steve.
On Thu, 2006-10-19 at 15:27 +0200, Adrian Bunk wrote:
> Don't dereference new->s_root when we do know it's NULL.
>
> Spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6/fs/gfs2/ops_fstype.c.old 2006-10-19 15:24:23.000000000 +0200
> +++ linux-2.6/fs/gfs2/ops_fstype.c 2006-10-19 15:24:32.000000000 +0200
> @@ -793,10 +793,10 @@ static int fill_super_meta(struct super_
> if (!new->s_root) {
> fs_err(sdp, "can't get root dentry\n");
> error = -ENOMEM;
> iput(inode);
> - }
> - new->s_root->d_op = &gfs2_dops;
> + } else
> + new->s_root->d_op = &gfs2_dops;
>
> return error;
> }
>
>
prev parent reply other threads:[~2006-10-19 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 13:27 Adrian Bunk
2006-10-19 14:09 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161266962.27980.146.camel@quoit.chygwyn.com \
--to=swhiteho@redhat.com \
--cc=bunk@stusta.de \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome