From: Daniel Drake <ddrake@brontes3d.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Andi Kleen <ak@suse.de>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: Unnecessary BKL contention in video1394
Date: Thu, 19 Oct 2006 11:31:01 -0400 [thread overview]
Message-ID: <1161271861.2845.12.camel@systems03.lan.brontes3d.com> (raw)
In-Reply-To: <45378D59.4060200@s5r6.in-berlin.de>
On Thu, 2006-10-19 at 16:36 +0200, Stefan Richter wrote:
> Thanks for the info. Daniel, do you want to resend a signed-off patch?
> And __video1394_ioctl and its wrapper video1394_ioctl can certainly be
> merged then.
Yep, I had already made that change locally. I will run it overnight on
several cameras just to be sure, and will send a patch tomorrow.
I also did some more investigation and straightened out my knowledge of
file_operations: release() can never be called while inside a read() or
ioctl(): This would imply that separate threads are in use, and the
driver's release() function is not called until *all* threads have
closed the fd. In other words I'm now much more confident that this
patch is not removing any necessary locking.
Daniel
prev parent reply other threads:[~2006-10-19 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1161203487.28713.8.camel@systems03.lan.brontes3d.com>
2006-10-18 21:36 ` Stefan Richter
2006-10-19 13:19 ` Daniel Drake
2006-10-19 13:27 ` Andi Kleen
2006-10-19 14:36 ` Stefan Richter
2006-10-19 15:31 ` Daniel Drake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161271861.2845.12.camel@systems03.lan.brontes3d.com \
--to=ddrake@brontes3d.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®