mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Wake Liu <wakel@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Shuah Khan <shuah@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Darren Hart <dvhart@infradead.org>,
	Davidlohr Bueso <dave@stgolabs.net>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2] selftests/futex: Skip futex_waitv tests if ENOSYS
Date: Fri, 8 Aug 2025 19:36:19 -0300	[thread overview]
Message-ID: <11620764-a95a-40dc-97be-ba6a9a39e71c@igalia.com> (raw)
In-Reply-To: <20250808071540.2122553-1-wakel@google.com>

Hi Wake Liu,

Em 08/08/2025 04:15, Wake Liu escreveu:
> The futex_waitv() syscall was introduced in Linux 5.16. The existing
> test in futex_wait_timeout.c will fail on kernels older than 5.16
> due to the syscall not being implemented.
> 
> Modify the test_timeout() function to check if the error returned
> is ENOSYS. If it is, skip the test and report it as such, rather than
> failing. This ensures the selftests can be run on a wider range of
> kernel versions without false negatives.
> 
> Signed-off-by: Wake Liu <wakel@google.com>
> ---
>   .../selftests/futex/functional/futex_wait_timeout.c    | 10 +++++++---
>   tools/testing/selftests/futex/functional/futex_waitv.c |  8 ++++++++

tools/testing/selftests/futex/functional/futex_wait_wouldblock.c also 
have a call for futex_waitv().

Apart from that, futex2_wait() and futex2_wake() syscalls may need 
something similar?


  reply	other threads:[~2025-08-08 22:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07 14:55 [PATCH] " Wake Liu
2025-08-08  7:15 ` [PATCH v2] " Wake Liu
2025-08-08 22:36   ` André Almeida [this message]
2025-08-09  8:32     ` Wake Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11620764-a95a-40dc-97be-ba6a9a39e71c@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wakel@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®