From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andy Adamson <andros@citi.umich.edu>,
"J. Bruce Fields" <bfields@citi.umich.edu>,
Olaf Kirch <okir@monad.swb.de>, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH 1/2] sunrpc: add missing spin_unlock
Date: Sun, 29 Oct 2006 15:21:59 -0500 [thread overview]
Message-ID: <1162153319.5545.62.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20061029133700.GA10295@localhost>
On Sun, 2006-10-29 at 22:37 +0900, Akinobu Mita wrote:
> auth_domain_put() forgot to unlock acquired spinlock.
ACK. (and added Neil to the CC list).
Cheers,
Trond
>
> Cc: Olaf Kirch <okir@monad.swb.de>
> Cc: Andy Adamson <andros@citi.umich.edu>
> Cc: J. Bruce Fields <bfields@citi.umich.edu>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
>
> Index: work-fault-inject/net/sunrpc/svcauth.c
> ===================================================================
> --- work-fault-inject.orig/net/sunrpc/svcauth.c
> +++ work-fault-inject/net/sunrpc/svcauth.c
> @@ -126,6 +126,7 @@ void auth_domain_put(struct auth_domain
> if (atomic_dec_and_lock(&dom->ref.refcount, &auth_domain_lock)) {
> hlist_del(&dom->hash);
> dom->flavour->domain_release(dom);
> + spin_unlock(&auth_domain_lock);
> }
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2006-10-29 20:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 18:55 [PATCH] auth_gss: unregister gss_domain when unloading module Akinobu Mita
2006-10-29 13:35 ` Akinobu Mita
2006-10-29 13:37 ` [PATCH 1/2] sunrpc: add missing spin_unlock Akinobu Mita
2006-10-29 13:38 ` [PATCH 2/2] auth_gss: unregister gss_domain when unloading module Akinobu Mita
2006-10-29 20:15 ` Trond Myklebust
2006-10-30 14:54 ` Akinobu Mita
2006-10-30 15:17 ` Trond Myklebust
2006-10-31 3:15 ` Akinobu Mita
2006-10-31 4:13 ` Neil Brown
2006-10-29 20:21 ` Trond Myklebust [this message]
2006-10-30 5:43 ` [PATCH 1/2] sunrpc: add missing spin_unlock Neil Brown
2006-10-30 14:57 ` [PATCH -mm] sunrpc/auth_gss: auth_domain refcount fix Akinobu Mita
2006-11-05 16:35 ` [PATCH 1/2] sunrpc: add missing spin_unlock Peter Zijlstra
2006-11-05 19:45 ` Andrew Morton
2006-11-05 19:58 ` Peter Zijlstra
2006-11-05 22:04 ` Elimar Riesebieter
2006-10-29 19:46 ` [PATCH] auth_gss: unregister gss_domain when unloading module Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162153319.5545.62.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=akinobu.mita@gmail.com \
--cc=andros@citi.umich.edu \
--cc=bfields@citi.umich.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=okir@monad.swb.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®