Re: [PATCH 2/2] Workaround for SB600 SATA ODD issue

[Arjan van de Ven <arjan@infradead.org>]

On Fri, 2006-11-03 at 14:00 -0500, Luugi Marsan wrote:
> From: conke.hu@amd.com
> 
> There was an ASIC bug in the SB600 SATA controller of low revision (<=13) and CD burning may hang (only SATA ODD has this issue, and SATA HDD works well). The patch provides a workaround for this issue.
> 
> Signed-off-by:  Luugi Marsan <luugi.marsan@amd.com>
> 
> --- linux-2.6.19-rc4-git5/drivers/ata/ahci.c.orig       2006-11-04 03:56:22.000000000 +0800
> +++ linux-2.6.19-rc4-git5/drivers/ata/ahci.c    2006-11-04 04:20:36.000000000 +0800
> @@ -189,6 +189,7 @@ struct ahci_host_priv {
>         unsigned long           flags;
>         u32                     cap;    /* cache of HOST_CAP register */
>         u32                     port_map; /* cache of HOST_PORTS_IMPL reg */
> +       u8                      rev;    /* PCI Revision ID */
>  };
>  

why put this into the ahci struct rather than in the pci device struct?
In the place you use it you already have the pci device struct already..
and it's really a pci device property so putting it in that struct makes
a whole lot of sense conceptually anyway...


-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org