From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161138AbWKEGcK (ORCPT ); Sun, 5 Nov 2006 01:32:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161171AbWKEGcK (ORCPT ); Sun, 5 Nov 2006 01:32:10 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:16777 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1161138AbWKEGcJ (ORCPT ); Sun, 5 Nov 2006 01:32:09 -0500 Subject: Re: Fw: Top 100 inline functions (make allyesconfig) was Re: [ANNOUNCE] pahole and other DWARF2 utilities From: David Woodhouse To: Andrew Morton Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, lwn@lwn.net, linux-mtd@lists.infradead.org In-Reply-To: <20061104132050.4950866b.akpm@osdl.org> References: <20061104132050.4950866b.akpm@osdl.org> Content-Type: text/plain Date: Sun, 05 Nov 2006 14:32:17 +0800 Message-Id: <1162708337.3374.21.camel@shinybook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1.1 (2.8.1.1-3.fc6.dwmw2.1) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2006-11-04 at 13:20 -0800, Andrew Morton wrote: > cfi_build_cmd() is nutty. Damn right it's nutty. Imagine the number of ways you can wire up 1-8 flash chips in either 8-bit or 16-bit mode to a bus which is between 8 and 64 bits wide. Deal with it in software, with a "chip driver" abstraction which knows what data to put at which address on each _chip_, and which needs to calculate the corresponding bus data/address. In the sensible case where you build in support for what you have -- one interleave, one mode, one bus size -- it's simple. And that's why it's inline. This is one of the cases where 'allyesconfig' just doesn't make much sense. I'm not entirely averse to taking it out-of-line, but show me data on the interesting case rather than the allyesconfig case. And tell me about it in about two weeks' time when the sky stops falling on my head and I get to go home. :) -- dwmw2