mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li@intel.com>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, bunk@stusta.de
Subject: Re: [patch] Regression in 2.6.19-rc microcode driver
Date: Tue, 07 Nov 2006 09:20:27 +0800	[thread overview]
Message-ID: <1162862427.22565.4.camel@sli10-conroe.sh.intel.com> (raw)
In-Reply-To: <1162822538.3138.28.camel@laptopd505.fenrus.org>

On Mon, 2006-11-06 at 15:15 +0100, Arjan van de Ven wrote:
> Hi,
> 
> if the microcode driver is built in (rather than module) there are some,
> ehm, interesting effects happening due to the new "call out to
> userspace" behavior that is introduced.. and which runs too early. The
> result is a boot hang; which is really nasty.
> 
> The patch below is a minimally safe patch to fix this regression for
> 2.6.19 by just not requesting actual microcode updates during early
> boot. (That is a good idea in general anyway)
> 
> The "real" fix is a lot more complex given the entire cpu hotplug
> scenario (during cpu hotplug you normally need to load the microcode as
> well); but the interactions for that are just really messy at this
> point; this fix at least makes it work and avoids a full detangle of
> hotplug.
Yes, this is an issue which I documented in my patch. It's not a hang,
but a long delay if you have many cpus. Other drivers with firmware
request have the same issue if they are built-in. Maybe we should fix
the firmware request mechanism itself. I hope no distribution has
microcode driver built-in.

Thanks,
Shaohua

  parent reply	other threads:[~2006-11-07  1:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06 14:15 Arjan van de Ven
2006-11-06 19:01 ` Andrew Morton
2006-11-06 19:02   ` Arjan van de Ven
2006-11-06 19:18   ` Arjan van de Ven
2006-11-07  1:20 ` Shaohua Li [this message]
2006-11-07  1:59   ` Andrew Morton
2006-11-07  9:13     ` Arjan van de Ven
2006-11-07  9:21       ` Andrew Morton
2006-11-07  9:35         ` Arjan van de Ven
2006-11-07  9:43         ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1162862427.22565.4.camel@sli10-conroe.sh.intel.com \
    --to=shaohua.li@intel.com \
    --cc=akpm@osdl.org \
    --cc=arjan@linux.intel.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®