Re: [PATCH] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal

[Amol Lad <amol@verismonetworks.com>]

On Tue, 2006-11-07 at 22:29 +0000, Christoph Hellwig wrote:
> On Mon, Nov 06, 2006 at 06:12:11PM +0530, Amol Lad wrote:
> > Replaced save_flags()/cli() with spin_lock alternatives
> 
> This patch has very little chance to work as-is because it only replaces
> cli with spinlocks, but not the irq handler it's locking against.
> 
It protects against irq handler also. 

drivers/scsi/NCR53C9x.c:

irqreturn_t esp_intr(int irq, void *dev_id)
{
    struct NCR_ESP *esp;
    unsigned long flags;
    int again;
    struct Scsi_Host *dev = dev_id;

    /* Handle all ESP interrupts showing at this IRQ level. */
    spin_lock_irqsave(dev->host_lock, flags);
...
...
}