Re: [patch 09/19] i386: Convert to clock event devices

[Arjan van de Ven <arjan@infradead.org>]

On Thu, 2006-11-09 at 23:38 +0000, Thomas Gleixner wrote:
> - * Local timer interrupt handler. It does both profiling and
> - * process statistics/rescheduling.
> + * The guts of the apic timer interrupt
>   */
> -inline void smp_local_timer_interrupt(void)
> +fastcall void local_apic_timer_interrupt(struct pt_regs *regs)

please don't add more "fastcall"; CONFIG_REGPARM makes that the default
anyway



> +void __init setup_pit_timer(void)
> +{
> +	pit_clockevent.mult = div_sc(CLOCK_TICK_RATE, NSEC_PER_SEC, 32);
> +	pit_clockevent.max_delta_ns =
> +		clockevent_delta2ns(0x7FFF, &pit_clockevent);
> +	pit_clockevent.min_delta_ns =
> +		clockevent_delta2ns(0xF, &pit_clockevent);
> +	register_global_clockevent(&pit_clockevent);
> +#ifdef CONFIG_HPET_TIMER
> +	global_clock_event = &pit_clockevent;
> +#endif
> +}

ok this ifdef looks really really weird to me. Why does PIT code depend
on CONFIG_HPET ? HPET is mostly a runtime property!


other than that Acked-by: Arjan van de Ven <arjan@linux.intel.com>

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org