From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1244C2BEC2B for ; Mon, 13 Apr 2026 11:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776079678; cv=none; b=JJ8kQ+SXjxQOxUzm5JlbEVPRRrs9DnzkXn8YiVy6Se+SghphO5XvBWLHWSWM6O9heHhs5KtBaRcSgWnovfaXKFfaqqTbs4ANGWTvB5mBIiiV+D7tp9LFiQAMVpWKh7bH5mLwYp1rctsjyTN5vLTmhdm4aoLd7o35/M92CLqoJRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776079678; c=relaxed/simple; bh=1V66m994SQyVyDOYYQ2DerYF/StQSxPSJ4YO7HRuc1U=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=Hyz7DQ1NERfrO/F/kt+x3mZIsOmPOigN5oC25iTv4cvoPcERZtQsR1PZ9AAlsc6eKCCDPQEYGr+/IPBVIp+0sK/sY/hzD08j77FBRwQKA6FCrgmaX1k57Utv0PpWIBrmX6zw3hDBZqE53RzSE40VeYvY8dHOktZ6TkYIfR2679o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sDtT38vb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sDtT38vb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90BD2C116C6; Mon, 13 Apr 2026 11:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776079677; bh=1V66m994SQyVyDOYYQ2DerYF/StQSxPSJ4YO7HRuc1U=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=sDtT38vbnXwBsWN+TnuqbGL2eZKAJ6nr35PsVglPzZ7KVMV8yWHmmfLu65N+4rW6V SFIgTO4quSF9g6x1ENMJiDwf3l2GwEoRidHyRLwUmWYemRWA5aUmXOs0AvJgPL92Ny Qhn/YHnLigw4Erxs71dk5YhbiKXALM8XggZMVniKbJ79sjqj5dWv0ROrKs5ozsVylJ raY4H8+bL7vaQQ4XCvKvdPDTIYDtOr4odod7Bd7/PDP8r4Q4ppLtPjbB8H47YfI/Lc 1cqWTbJXgoqyTsSMY00mIfl91tG6Enp17jFYSinJJS7VP5PHTZ9MNA+XVg/37A1UdL 4LClhKAX9d8Sw== Message-ID: <116344cd-c591-42c9-9593-2e999c2029d8@kernel.org> Date: Mon, 13 Apr 2026 19:27:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org Subject: Re: [f2fs-dev] [PATCH v3] f2fs: do not support mmap write for large folio To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20260406154940.2407853-1-jaegeuk@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/9/2026 2:13 AM, Jaegeuk Kim via Linux-f2fs-devel wrote: > Let's check mmap writes onto the large folio, since we don't support writing > large folios. > > Reviewed-by: Daeho Jeong > Signed-off-by: Jaegeuk Kim > --- > > - log v2: > : add comments > > fs/f2fs/file.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 2c4880f24b54..c0220cd7b332 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -82,7 +82,12 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) > int err = 0; > vm_fault_t ret; > > - if (unlikely(IS_IMMUTABLE(inode))) > + /* > + * We only support large folio on the read case. > + * Don't make any dirty pages. > + */ > + if (unlikely(IS_IMMUTABLE(inode)) || > + mapping_large_folio_support(inode->i_mapping)) > return VM_FAULT_SIGBUS; The code itself looks good, since it's an impossible case, should we use f2fs_bug_on(, mapping_large_folio_support()) to catch any bug case rather than just returning error here w/o log? Thanks, > > if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {