From: Johannes Berg <johannes@sipsolutions.net>
To: Stelian Pop <stelian@popies.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Morton <akpm@osdl.org>,
Michael Hanselmann <linux-kernel@hansmi.ch>,
"Aristeu S. Rozanski F." <aris@cathedrallabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Robert Love <rml@novell.com>,
Jean Delvare <khali@linux-fr.org>,
Rene Nussbaumer <linux-kernel@killerfox.forkbomb.ch>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Apple Motion Sensor driver
Date: Mon, 13 Nov 2006 22:23:59 +0100 [thread overview]
Message-ID: <1163453039.5399.19.camel@johannes.berg> (raw)
In-Reply-To: <1163451174.23807.18.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
> The fact that the accelerometer offers a (low res) joystick emulation is
> only a nice hack and I'm not even sure somebody (except Johannes) will
> find an use for it.
Heh. Well I think it's fun once a while :)
On Mon, 2006-11-13 at 21:52 +0100, Stelian Pop wrote:
>
> + x -= ams_info.xcalib;
> + y -= ams_info.ycalib;
> + z -= ams_info.zcalib;
> +
> + input_report_abs(ams_info.idev, ABS_X, invert ? -x : x);
> + input_report_abs(ams_info.idev, ABS_Y, invert ? -y : y);
> + input_report_abs(ams_info.idev, ABS_Z, z - ams_info.zcalib);
You're double-calibrating z now, which is surely not what was intended.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2006-11-13 21:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-11 21:36 Stelian Pop
2006-11-11 21:41 ` Michael Hanselmann
2006-11-11 22:00 ` Stelian Pop
2006-11-12 8:37 ` Michael Hanselmann
2006-11-12 21:38 ` Stelian Pop
2006-11-13 18:11 ` Jean Delvare
2006-11-13 18:18 ` Dmitry Torokhov
2006-11-13 15:04 ` Dmitry Torokhov
2006-11-13 15:29 ` Stelian Pop
2006-11-13 15:53 ` Dmitry Torokhov
2006-11-13 16:14 ` Stelian Pop
2006-11-13 16:20 ` Johannes Berg
2006-11-13 18:14 ` Jean Delvare
2006-11-13 18:18 ` Johannes Berg
2006-11-13 18:24 ` Michael Hanselmann
2006-11-13 20:55 ` Stelian Pop
2006-11-13 18:20 ` Dmitry Torokhov
2006-11-13 18:55 ` Robert Love
2006-11-13 20:52 ` Stelian Pop
2006-11-13 21:23 ` Johannes Berg [this message]
2006-11-13 21:39 ` Stelian Pop
2006-11-13 18:06 ` Jean Delvare
2006-11-13 18:23 ` Henrique de Moraes Holschuh
2006-11-13 20:41 ` Stelian Pop
2006-11-14 3:09 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163453039.5399.19.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=akpm@osdl.org \
--cc=aris@cathedrallabs.org \
--cc=benh@kernel.crashing.org \
--cc=dmitry.torokhov@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@killerfox.forkbomb.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rml@novell.com \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®