From: Mike Galbraith <efault@gmx.de>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: nickpiggin@yahoo.com.au, "'Ingo Molnar'" <mingo@elte.hu>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] sched: optimize activate_task for RT task - v2
Date: Wed, 15 Nov 2006 09:24:06 +0100 [thread overview]
Message-ID: <1163579046.7035.29.camel@Homer.simpson.net> (raw)
In-Reply-To: <1163574019.6175.30.camel@Homer.simpson.net>
On Wed, 2006-11-15 at 08:00 +0100, Mike Galbraith wrote:
> Personally, I think it's best to leave it as it is. With that change,
> if someone changes policy while the task is waiting to get cpu, it will
> be requeued, and the on-runqueue bonus logic will then end up using
> wildly inaccurate information.
Bah, that's inverted. interactive_sleep() will never be true after a
rt->non-rt policy change while enqueued with your change, so on-runqueue
bonus will be disabled where it otherwise might have been enabled. Not
terribly interesting in any case given the likelihood, but still...
-Mike
prev parent reply other threads:[~2006-11-15 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 23:55 Chen, Kenneth W
2006-11-15 7:00 ` Mike Galbraith
2006-11-15 8:24 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163579046.7035.29.camel@Homer.simpson.net \
--to=efault@gmx.de \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome