mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Tony Olech <tony.olech@elandigitalsystems.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
	Linux kernel development <linux-kernel@vger.kernel.org>,
	PCMCIA Maintainence <linux-pcmcia@lists.infradead.org>,
	David Hinds <dahinds@users.sourceforge.net>,
	Jaroslav Kysela <perex@suse.cz>,
	Bart Prescott <bart.prescott@elandigitalsystems.com>
Subject: Re: [PATCH] PCMCIA identification strings for cards manufactured by Elan
Date: Mon, 20 Nov 2006 13:51:25 +0100	[thread overview]
Message-ID: <1164027086.31358.588.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200611201214.kAKCErcU005240@imap.elan.private>

Hi,

> a card is inserted, resulting in various random lockups
> 
> *** linux-2.6.18/sound/pcmcia/pdaudiocf/pdaudiocf.c.orig	2006-11-20 10:24:23.000000000 +0000
> --- linux-2.6.18/sound/pcmcia/pdaudiocf/pdaudiocf.c	2006-11-20 10:33:46.000000000 +0000
> ***************
> *** 298,306 ****
>   /*
>    * Module entry points
>    */
>   static struct pcmcia_device_id snd_pdacf_ids[] = {
> ! 	PCMCIA_DEVICE_MANF_CARD(0x015d, 0x4c45),


please use the "-u" option for diff; that's the preferred (only) form
the Linux kernel folks are used to looking at diffs, and applying them.
Also, it's very helpful and customary to also pass the "-p" option (this
improves the context so that reviews are easier)

would you mind redoing the diff and then resending it?

Thanks!


-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org


  reply	other threads:[~2006-11-20 12:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20 11:17 Tony Olech
2006-11-20 12:51 ` Arjan van de Ven [this message]
2006-11-20 13:02 ` Russell King
2006-11-20 14:23   ` Tony Olech
2006-11-20 15:29     ` Russell King
2006-11-20 16:51       ` Tony Olech
2006-11-20 17:27         ` Russell King
2006-11-20 17:39           ` David Hinds
2006-11-20 17:45           ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1164027086.31358.588.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=bart.prescott@elandigitalsystems.com \
    --cc=dahinds@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux@dominikbrodowski.net \
    --cc=perex@suse.cz \
    --cc=tony.olech@elandigitalsystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®