From: Ingo Molnar <mingo@redhat.com>
To: Pavel Emelianov <xemul@openvz.org>
Cc: Vivek Goyal <vgoyal@in.ibm.com>, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kirill Korotaev <dev@sw.ru>
Subject: Re: [RFC][PATCH] Fix locking on misrouted interrupts
Date: Tue, 21 Nov 2006 21:26:00 +0100 [thread overview]
Message-ID: <1164140760.15988.52.camel@earth> (raw)
In-Reply-To: <4562BD4E.20600@openvz.org>
On Tue, 2006-11-21 at 11:48 +0300, Pavel Emelianov wrote:
> Vivek noted that many places call note_interrupt()
> without desc->lock being held. Since note_interrupt()
> which tries to unlock this lock to handle spurious
> interrupts accodring to
> http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f72fa707604c015a6625e80f269506032d5430dc
>
> Looking at note_interrupt() I found that desc->lock
> IS required in this function but all the places that
> call note_interrupt() lock it after the call. One
> exception from this rule is __do_IRQ().
>
> So I move spin_lock(&desc->lock); before calling
> note_interrupt() in all places.
>
> Signed-off-bt: Pavel Emelianov <xemul@openvz.org>
indeed - and this is a fallout of the earlier fix in note_interrupt().
Andrew, Linus: i think this is a must-have for 2.6.19 as well.
Acked-by: Ingo Molnar <mingo@redhat.com>
Ingo
prev parent reply other threads:[~2006-11-21 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 8:48 Pavel Emelianov
2006-11-21 20:26 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164140760.15988.52.camel@earth \
--to=mingo@redhat.com \
--cc=akpm@osdl.org \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®