mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: ak@suse.de
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: [patch] Mark rdtsc as sync only for netburst, not for core2
Date: Tue, 28 Nov 2006 11:28:28 +0100	[thread overview]
Message-ID: <1164709708.3276.72.camel@laptopd505.fenrus.org> (raw)

Hi,

On the Core2 cpus, the rdtsc instruction is not serializing (as defined
in the architecture reference since rdtsc exists) and due to the deep
speculation of these cores, it's possible that you can observe time go
backwards between cores due to this speculation. Since the kernel
already deals with this with the SYNC_RDTSC flag, the solution is
simple, only assume that the instruction is serializing on family 15...

The price one pays for this is a slightly slower gettimeofday (by a
dozen or two cycles), but that increase is quite small to pay for a
really-going-forward tsc counter.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

--- linux-2.6.18/arch/x86_64/kernel/setup.c.org	2006-11-28 11:22:08.000000000 +0100
+++ linux-2.6.18/arch/x86_64/kernel/setup.c	2006-11-28 11:22:50.000000000 +0100
@@ -854,7 +854,10 @@ static void __cpuinit init_intel(struct 
 		set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability);
 	if (c->x86 == 6)
 		set_bit(X86_FEATURE_REP_GOOD, &c->x86_capability);
-	set_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability);
+	if (c->x86 == 15)
+		set_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability);
+	else
+		clear_bit(X86_FEATURE_SYNC_RDTSC, &c->x86_capability);
  	c->x86_max_cores = intel_num_cpu_cores(c);
 
 	srat_detect_node();


             reply	other threads:[~2006-11-28 10:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28 10:28 Arjan van de Ven [this message]
2006-11-28 10:36 ` Andi Kleen
     [not found]   ` <1164774239.15257.5.camel@ymzhang>
2006-11-29  7:30     ` Arjan van de Ven
2006-11-29  8:05       ` Nick Piggin
2006-11-29  9:04         ` Zhang, Yanmin
     [not found]       ` <1164787104.2899.7.camel@ymzhang>
2006-11-29  8:35         ` Arjan van de Ven
2006-11-29  9:07           ` Zhang, Yanmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1164709708.3276.72.camel@laptopd505.fenrus.org \
    --to=arjan@linux.intel.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®