From: Steven Whitehouse <swhiteho@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [GFS2] split gfs2_dinode into on-disk and host variants [1/70]
Date: Thu, 30 Nov 2006 12:36:56 +0000 [thread overview]
Message-ID: <1164890216.3752.457.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <20061130122538.GA27549@infradead.org>
Hi,
On Thu, 2006-11-30 at 12:25 +0000, Christoph Hellwig wrote:
> > + struct gfs2_dinode_host *di = &ip->i_di;
>
> Please call this things just gfs2_inode. gfs_d(isk)_inode_host doesn't
> make any sense.
>
Its not the final intention to keep this dinode_host structure (or
indeed the other _host structures introduced by Al's patches), its a
means to an end. Later patches in my inode shrinking series remove a
number of the fields from it, so it is much smaller. I do want to do
what you are requesting eventually, but I'm working on it a stage at a
time now that Al has pushed me in the right direction,
Steve.
prev parent reply other threads:[~2006-11-30 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 12:12 Steven Whitehouse
2006-11-30 12:25 ` Christoph Hellwig
2006-11-30 12:36 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164890216.3752.457.camel@quoit.chygwyn.com \
--to=swhiteho@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome