From: Marcel Holtmann <marcel@holtmann.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hci endianness annotations
Date: Fri, 08 Dec 2006 12:58:01 +0100 [thread overview]
Message-ID: <1165579081.5529.31.camel@aeonflux.holtmann.net> (raw)
In-Reply-To: <20061208094855.GR4587@ftp.linux.org.uk>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
> include/net/bluetooth/hci.h | 4 ++--
> net/bluetooth/hci_sock.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 10a3eec..41456c1 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -739,13 +739,13 @@ #define HCI_DEV_NONE 0xffff
> struct hci_filter {
> unsigned long type_mask;
> unsigned long event_mask[2];
> - __u16 opcode;
> + __le16 opcode;
> };
>
> struct hci_ufilter {
> __u32 type_mask;
> __u32 event_mask[2];
> - __u16 opcode;
> + __le16 opcode;
> };
>
> #define HCI_FLT_TYPE_BITS 31
> diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
> index 711a085..dbf98c4 100644
> --- a/net/bluetooth/hci_sock.c
> +++ b/net/bluetooth/hci_sock.c
> @@ -123,10 +123,10 @@ void hci_send_to_sock(struct hci_dev *hd
> if (flt->opcode &&
> ((evt == HCI_EV_CMD_COMPLETE &&
> flt->opcode !=
> - get_unaligned((__u16 *)(skb->data + 3))) ||
> + get_unaligned((__le16 *)(skb->data + 3))) ||
> (evt == HCI_EV_CMD_STATUS &&
> flt->opcode !=
> - get_unaligned((__u16 *)(skb->data + 4)))))
> + get_unaligned((__le16 *)(skb->data + 4)))))
> continue;
> }
>
prev parent reply other threads:[~2006-12-08 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 9:48 Al Viro
2006-12-08 11:58 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165579081.5529.31.camel@aeonflux.holtmann.net \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®