From: Daniel Walker <dwalker@mvista.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -rt][RESEND] fix preempt hardirqs on OMAP
Date: Mon, 11 Dec 2006 11:59:20 -0800 [thread overview]
Message-ID: <1165867160.8103.36.camel@imap.mvista.com> (raw)
In-Reply-To: <20061211195401.GA12440@flint.arm.linux.org.uk>
On Mon, 2006-12-11 at 19:54 +0000, Russell King wrote:
> > > what if the irq got disabled meanwhile? Also, chip->enable is a
> > > compatibility method, not something we should use in a flow handler.
> >
> > I don't know how other arches deal with IRQ_PENDING, but ARM (OMAP at
> > least) disables the IRQ on IRQ_PENDING.
>
> Please point out where it's doing that, and I'll take a look to see
> if it's doing something it shouldn't.
It's in arch/arm/plat-omap/gpio.c . It uses the lowlevel function to
disable the interrupt, not chip->disable() . In gpio_irq_handler() .
Daniel
prev parent reply other threads:[~2006-12-11 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-10 16:35 Daniel Walker
2006-12-11 19:05 ` Ingo Molnar
2006-12-11 19:38 ` Daniel Walker
2006-12-11 19:53 ` Tony Lindgren
2006-12-11 19:54 ` Russell King
2006-12-11 19:59 ` Daniel Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165867160.8103.36.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®