From: Nigel Cunningham <nigel@suspend2.net>
To: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fix swapped parameters in mm/vmscan.c.
Date: Tue, 12 Dec 2006 21:37:18 +1100 [thread overview]
Message-ID: <1165919838.31777.49.camel@nigel.suspend2.net> (raw)
The version of mm/vmscan.c in Linus' current tree has swapped parameters
in the shrink_all_zones declaration and call, used by the various
suspend-to-disk implementations. This doesn't seem to have any great
adverse effect, but it's clearly wrong.
Signed-off-by: Nigel Cunningham <nigel@suspend2.net>
diff -ruNp 930-vmscan.patch-old/mm/vmscan.c 930-vmscan.patch-new/mm/vmscan.c
--- 930-vmscan.patch-old/mm/vmscan.c 2006-12-12 12:24:05.000000000 +1100
+++ 930-vmscan.patch-new/mm/vmscan.c 2006-12-12 12:23:52.000000000 +1100
@@ -1443,8 +1443,8 @@ void wakeup_kswapd(struct zone *zone, in
*
* For pass > 3 we also try to shrink the LRU lists that contain a few pages
*/
-static unsigned long shrink_all_zones(unsigned long nr_pages, int pass,
- int prio, struct scan_control *sc)
+static unsigned long shrink_all_zones(unsigned long nr_pages, int prio,
+ int pass, struct scan_control *sc)
{
struct zone *zone;
unsigned long nr_to_scan, ret = 0;
reply other threads:[~2006-12-12 10:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165919838.31777.49.camel@nigel.suspend2.net \
--to=nigel@suspend2.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®