mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Peter Staubach <staubach@redhat.com>
Cc: linuxer linuxer <tangzt@yahoo.com>,
	linux-kernel@vger.kernel.org, torvalds@osdl.org, alan@redhat.com
Subject: Re: hi, should these code is a problem in nfs system clnt.c?
Date: Tue, 12 Dec 2006 11:11:45 -0500	[thread overview]
Message-ID: <1165939906.5788.36.camel@lade.trondhjem.org> (raw)
In-Reply-To: <457EB5E6.9060207@redhat.com>

On Tue, 2006-12-12 at 09:00 -0500, Peter Staubach wrote:
> linuxer linuxer wrote:
> > Hi, everyone: 
> >     I am a newbie, if my question waste your time, I
> > am sorry for that. 
> >
> >     In clnt.c file ,call_timeout function:    
> >     I suggest the code that judge whether the network
> > link status is down should be added, won't they? 
> >     I tested it with one Ethernet netcard.
> >
> >   
> 
> This would not be a good idea.  What happens if the name of the
> interface used on the system is not "eth0"?
> 
> Also, IP packets can be routed out of any available interface,
> so just because one interface (eth0) is down, doesn't mean
> that the entire system is networkless.

Right. Besides, it is also an obvious layering violation. Idea NAKed.

Trond


      reply	other threads:[~2006-12-12 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-12  7:40 linuxer linuxer
2006-12-12 14:00 ` Peter Staubach
2006-12-12 16:11   ` Trond Myklebust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1165939906.5788.36.camel@lade.trondhjem.org \
    --to=trond.myklebust@fys.uio.no \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=staubach@redhat.com \
    --cc=tangzt@yahoo.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®