From: James Bottomley <James.Bottomley@SteelEye.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 5/5] scsi: fix uaccess handling
Date: Fri, 15 Dec 2006 11:36:37 -0600 [thread overview]
Message-ID: <1166204197.2846.22.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20061029213922.GA8494@osiris.ibm.com>
On Sun, 2006-10-29 at 22:39 +0100, Heiko Carstens wrote:
> > While not your fault I'd suggest to fix the __put_user abuse at the same
> > time, as in the untested patch below for scsi_ioctl.c:
>
> Makes sense. Even though the whole SCSI_IOCTL_GET_IDLUN ioctl interface
> is pretty pointless.
> It supports only up to 255 different ids and luns and might return the
> same 'dev_id' for two different devices...
> Any user space utility that depends on this interface would do the wrong
> thing (whatever that would be).
So has anyone actually tested this?
James
prev parent reply other threads:[~2006-12-15 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 13:00 [patch 0/5] various user space access fixes Heiko Carstens
2006-10-26 13:01 ` [patch 1/5] binfmt: fix uaccess handling Heiko Carstens
2006-10-27 4:37 ` Andrew Morton
2006-10-26 13:02 ` [patch 2/5] compat: " Heiko Carstens
2006-10-26 13:03 ` [patch 3/5] net: " Heiko Carstens
2006-10-30 23:06 ` David Miller
2006-10-26 13:04 ` [patch 4/5] profile: " Heiko Carstens
2006-10-26 13:04 ` [patch 5/5] scsi: " Heiko Carstens
2006-10-28 11:31 ` Christoph Hellwig
2006-10-29 21:39 ` Heiko Carstens
2006-12-15 17:36 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166204197.2846.22.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®