From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932809AbWLSMRj (ORCPT ); Tue, 19 Dec 2006 07:17:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932808AbWLSMRj (ORCPT ); Tue, 19 Dec 2006 07:17:39 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:35079 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932803AbWLSMRi (ORCPT ); Tue, 19 Dec 2006 07:17:38 -0500 Subject: Re: [patch 1/2] agpgart - allow user-populated memory types. From: Arjan van de Ven To: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= Cc: Dave Jones , Dave Airlie , Linux Kernel list In-Reply-To: <4587B47F.20008@tungstengraphics.com> References: <4579ADE3.6040609@tungstengraphics.com> <1165616236.27217.108.camel@laptopd505.fenrus.org> <1095.213.114.71.166.1165619148.squirrel@www.shipmail.org> <1166518064.3365.1188.camel@laptopd505.fenrus.org> <4587B47F.20008@tungstengraphics.com> Content-Type: text/plain Organization: Intel International BV Date: Tue, 19 Dec 2006 13:17:29 +0100 Message-Id: <1166530649.3365.1237.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 (2.8.2.1-2.fc6) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > A short background: > The current code uses vmalloc only. The potential use of kmalloc was > introduced > to save memory and cpu-speed. > All agp drivers expect to see a single memory chunk, so I'm not sure we > want to have an array of pages. That may require rewriting a lot of code. but if it's clearly the right thing..... How hard can it be? there are what.. 5 or 6 AGP drivers in the kernel? > If it's acceptable I'd like to go for the vmalloc / kmalloc flag, or at > worst keep the current vmalloc only but that's such a _huge_ memory > waste for small buffers. The flag was the original idea, but > unfortunately the agp_memory struct is part of the drm interface, and I > wasn't sure we could add a variable to it. I doubt this is part of the userspace interface so for sure we can change it to be right. -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org