From: Arjan van de Ven <arjan@infradead.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: locking issue (hardirq+softirq+user)
Date: Wed, 20 Dec 2006 14:50:18 +0100 [thread overview]
Message-ID: <1166622618.3365.1389.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <45893C1C.60305@gmail.com>
On Wed, 2006-12-20 at 14:35 +0100, Jiri Slaby wrote:
> Hi!
>
> an user still gets NMI watchdog warning, that the machine deadlocked.
have you tried enabling LOCKDEP ?
> isr() /* i.e. hardirq context */
> {
> spin_lock(&lock);
> ...
> spin_unlock(&lock);
> }
this is ok if you are 100% sure that this never gets called in any other
way
>
> timer() /* i.e. softirq context */
> {
> unsigned int f;
> spin_lock_irqsave(&lock, f) /* stack shows, that it locks here */
this is a bug, the flags are an "unsigned long" not "unsigned int"!
It may do really bad stuff!
Greetings,
Arjan van de Ven
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org
next prev parent reply other threads:[~2006-12-20 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 13:35 Jiri Slaby
2006-12-20 13:50 ` Arjan van de Ven [this message]
2006-12-20 13:59 ` Jiri Slaby
2006-12-20 22:28 ` linux-os (Dick Johnson)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166622618.3365.1389.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®