From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Chris Wright <chrisw@sous-sol.org>, Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] videobuf_qbuf: fix? possible videobuf_queue->stream corruption and lockup
Date: Tue, 23 Jan 2007 21:10:08 -0200 [thread overview]
Message-ID: <1169593808.18437.4.camel@areia> (raw)
In-Reply-To: <20070123175714.GA299@tv-sign.ru>
Em Ter, 2007-01-23 às 20:57 +0300, Oleg Nesterov escreveu:
> I am pretty sure the bug is real, but the patch may be wrong, please review.
>
> We are doing ->buf_prepare(buf) before adding buf to q->stream list. This
> means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Chris/Adrian,
IMO, this should also be applied at -stable trees.
>
> --- 6.19/drivers/media/video/video-buf.c~v4l_lockup 2006-11-17 19:42:25.000000000 +0300
> +++ 6.19/drivers/media/video/video-buf.c 2007-01-23 19:44:19.000000000 +0300
> @@ -700,6 +700,7 @@ videobuf_qbuf(struct videobuf_queue *q,
> goto done;
> }
> if (buf->state == STATE_QUEUED ||
> + buf->state == STATE_PREPARED ||
> buf->state == STATE_ACTIVE) {
> dprintk(1,"qbuf: buffer is already queued or active.\n");
> goto done;
>
next prev parent reply other threads:[~2007-01-23 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 17:57 Oleg Nesterov
2007-01-23 23:10 ` Mauro Carvalho Chehab [this message]
2007-02-21 12:02 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169593808.18437.4.camel@areia \
--to=mchehab@infradead.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®