mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: TJ <linux@tjworld.net>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Neil Brown <neilb@suse.de>, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] filesystem: Disk Errors at boot-time caused by probe of partitions
Date: Thu, 01 Feb 2007 01:50:33 +0000	[thread overview]
Message-ID: <1170294633.7511.4.camel@butch.lan.tjworld.net> (raw)

From: TJ <linux@tjworld.net>

Applies to: up-to and including 2.6.20-rc7 

Update to previous patch.

Fixed logical error in if() statements for conditional printk(). Replaced bit-wise OR with AND.

Signed-off-by: TJ <linux@tjworld.net>

--- fs/partitions/msdos.tj.c	2007-02-01 00:41:57.000000000 +0000
+++ fs/partitions/msdos.tj.1.c	2007-02-01 01:07:31.000000000 +0000
@@ -459,13 +459,13 @@ int check_sane_values(struct partition *
 		if (insane) { /* insanity found; report it */
 			ret = -1; /* error code */
 			printk("\n"); /* start error report on a fresh line */
-			if (insane | 1)
+			if (insane & 1)
 				printk(" partition %d: start (sector %d) beyond end of disk (sector %d)\n",
 				 slot, START_SECT(p), (unsigned int) bdev->bd_disk->capacity-1);
-			if (insane | 2)
+			if (insane & 2)
 				printk(" partition %d: end (sector %d) beyond end of disk (sector %d)\n",
 				 slot, START_SECT(p)+NR_SECTS(p)-1, (unsigned int) bdev->bd_disk->capacity-1);
-			if (insane | 4)
+			if (insane & 4)
 				printk(" partition %d: insane extended contents\n", slot);
 		}
 	}





             reply	other threads:[~2007-02-01  1:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-01  1:50 TJ [this message]
     [not found] <fa.vUjkpPQXmle+uox6D228qG85KCU@ifi.uio.no>
2007-02-01  4:20 ` Robert Hancock
2007-02-01 11:27   ` TJ
2007-02-01 19:12     ` Phillip Susi
2007-02-01 20:42       ` Alan
  -- strict thread matches above, loose matches on Subject: below --
2007-01-31 23:50 TJ
2007-02-01 22:26 ` Andrew Morton
2007-02-01 22:47   ` Eric D. Mudama
2007-02-01 23:50   ` TJ
2007-02-02  0:10     ` Eric D. Mudama
2007-02-02  0:25       ` TJ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1170294633.7511.4.camel@butch.lan.tjworld.net \
    --to=linux@tjworld.net \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®