From: Anton Altaparmakov <aia21@cam.ac.uk>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
aia21@cantab.net
Subject: Re: [PATCH] NTFS: Rename apparently incorrect macro name "NTFS_DEBUG".
Date: Fri, 02 Feb 2007 11:10:29 +0000 [thread overview]
Message-ID: <1170414630.5749.0.camel@imp.csi.cam.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0702020543230.16913@CPE00045a9c397f-CM001225dbafb6>
Hi,
On Fri, 2007-02-02 at 05:46 -0500, Robert P. J. Day wrote:
> Replace the apparently incorrect macro name "NTFS_DEBUG" with
> "CONFIG_NTFS_DEBUG".
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> index c577d8e..2154d03 100644
> --- a/fs/ntfs/attrib.c
> +++ b/fs/ntfs/attrib.c
> @@ -1921,7 +1921,7 @@ s64 ntfs_attr_extend_allocation(ntfs_inode *ni, s64 new_alloc_size,
> u32 attr_len = 0; /* Silence stupid gcc warning. */
> bool mp_rebuilt;
>
> -#ifdef NTFS_DEBUG
> +#ifdef CONFIG_NTFS_DEBUG
The fix is also wrong. It should be:
#ifdef DEBUG
See fs/ntfs/Makefile for details...
> read_lock_irqsave(&ni->size_lock, flags);
> allocated_size = ni->allocated_size;
> read_unlock_irqrestore(&ni->size_lock, flags);
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/
next prev parent reply other threads:[~2007-02-02 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 10:46 Robert P. J. Day
2007-02-02 11:10 ` Anton Altaparmakov [this message]
2007-02-02 11:14 ` Anton Altaparmakov
2007-02-02 11:22 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170414630.5749.0.camel@imp.csi.cam.ac.uk \
--to=aia21@cam.ac.uk \
--cc=aia21@cantab.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®