mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Miguel Ojeda <maxextreme@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm] cfag12864b: fix crash when built-in and no parport present
Date: Tue, 13 Feb 2007 01:16:36 -0800	[thread overview]
Message-ID: <1171358197.32073.182.camel@imap.mvista.com> (raw)
In-Reply-To: <20070212213557.4b28e567.akpm@linux-foundation.org>

On Mon, 2007-02-12 at 21:35 -0800, Andrew Morton wrote:

> 
> This looks hacky.
> 

One other thing that could be added is a change in the initcalls .
ks0108 should be subsys_initcall() and the LCD devices
device_initcall(). That would make sure one runs before the other. I
don't think that alone would fix the crash tho. I didn't suggest it
before cause I think the order of the sources in the build system might
do this implicitly even if both are in device_initcall ..

Daniel


  parent reply	other threads:[~2007-02-13  9:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10 19:51 Miguel Ojeda
2007-02-12 19:52 ` Daniel Walker
2007-02-13  5:35 ` Andrew Morton
2007-02-13  6:29   ` Miguel Ojeda
2007-02-13  9:16   ` Daniel Walker [this message]
2007-02-13 13:29     ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171358197.32073.182.camel@imap.mvista.com \
    --to=dwalker@mvista.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxextreme@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome