From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751945AbdJBUaL (ORCPT <rfc822;w@1wt.eu>);
        Mon, 2 Oct 2017 16:30:11 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:30172 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751736AbdJBUaI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Oct 2017 16:30:08 -0400
Subject: Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables
To: David Miller <davem@davemloft.net>, avinash.repaka@oracle.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org
References: <1506734030-15205-1-git-send-email-avinash.repaka@oracle.com>
 <20171001.225419.1632354964848604960.davem@davemloft.net>
 <20171001.225655.1261950191787562705.davem@davemloft.net>
From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Organization: Oracle Corporation
Message-ID: <1172819f-1c28-7756-4874-aa89f50c0733@oracle.com>
Date: Mon, 2 Oct 2017 13:30:43 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171001.225655.1261950191787562705.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/1/2017 10:56 PM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sun, 01 Oct 2017 22:54:19 -0700 (PDT)
> 
>> From: Avinash Repaka <avinash.repaka@oracle.com>
>> Date: Fri, 29 Sep 2017 18:13:50 -0700
>>
>>> This patch fixes the scope of has_fr and has_fmr variables as they are
>>> needed only in rds_ib_add_one().
>>>
>>> Signed-off-by: Avinash Repaka <avinash.repaka@oracle.com>
>>
>> Applied.
> 
> Actually, reverted, this breaks the build.
> 
> net/rds/rdma_transport.c:38:10: fatal error: ib.h: No such file or directory
>   #include "ib.h"
> 
> Although I can't see how in the world this patch is causing such
> an error.
> 
Weird indeed. Will sort this out with Avinash. Thanks Dave.

Regards,
Santosh