From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933203AbXCEVOg (ORCPT ); Mon, 5 Mar 2007 16:14:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933228AbXCEVOg (ORCPT ); Mon, 5 Mar 2007 16:14:36 -0500 Received: from mx1.redhat.com ([66.187.233.31]:51314 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933203AbXCEVOf (ORCPT ); Mon, 5 Mar 2007 16:14:35 -0500 Subject: RE: [PATCH] xfrm_policy delete security check misplaced From: Eric Paris To: James Morris Cc: Venkat Yekkirala , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Venkat Yekkirala , cxzhang@watson.ibm.com, Stephen Smalley In-Reply-To: References: <001501c75f3f$243a3000$cc0a010a@tcssec.com> Content-Type: text/plain Date: Mon, 05 Mar 2007 11:51:28 -0500 Message-Id: <1173113488.31047.36.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 (2.6.3-1.fc5.5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2007-03-05 at 11:39 -0500, James Morris wrote: > On Mon, 5 Mar 2007, Venkat Yekkirala wrote: > > > > > > > Signed-off-by: Eric Paris > > Acked-by: Venkat Yekkirala > > What about your previous comment: > > "I guess you meant to do this here? > else if (err) > return err; " That also gets taken care of in the pfkey_spdget cleanup in a later patch. The return isn't in that same place venkat suggested it instead happens inside the new if (delete) block. (err is only non-zero on delete operations so there is no need to check it otherwise) -Eric