From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Will Trives <will@trivescon.com.au>,
linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
Chuck Ebbert <cebbert@redhat.com>
Subject: Re: [PATCH] fs: nobh_truncate_page() fix
Date: Mon, 05 Mar 2007 17:10:11 -0600 [thread overview]
Message-ID: <1173136211.9109.81.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <20070305145753.1180a1d4.akpm@linux-foundation.org>
On Mon, 2007-03-05 at 14:57 -0800, Andrew Morton wrote:
> Is OK, I think. nobh_prepare_write() brings the outside-from-and-to
> sections of the page uptodate and memset in nobh_truncate_page() brings the
> rest of the page uptodate.
>
> We bring the to->PAGE_CACHE_SIZE section uptodate twice, which could be
> optimised.
Why not have nobh_truncate_page() call prepare_write() with to =
PAGE_CACHE_SIZE? I don't really grok:
to = (offset + blocksize) & ~(blocksize - 1);
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2007-03-05 23:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 4:03 2.6.21-rc2-git3 Unstable for me Will Trives
2007-03-05 14:59 ` Chuck Ebbert
2007-03-05 15:36 ` Dave Kleikamp
2007-03-05 15:50 ` Dave Kleikamp
2007-03-05 20:58 ` [PATCH] fs: nobh_truncate_page() fix Dave Kleikamp
2007-03-05 21:43 ` Linus Torvalds
2007-03-05 22:57 ` Andrew Morton
2007-03-05 23:10 ` Dave Kleikamp [this message]
2007-03-05 23:31 ` Andrew Morton
2007-03-05 23:02 ` Dave Kleikamp
2007-03-05 22:25 ` 2.6.21-rc2-git3 Unstable for me Will Trives
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173136211.9109.81.camel@kleikamp.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@linux-foundation.org \
--cc=will@trivescon.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®