From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel@redhat.com
Cc: Abhijith Das <adas@redhat.com>, linux-kernel@vger.kernel.org
Subject: [GFS2] Fix bz 229873, alternate test: assertion "!ip->i_inode.i_mapping->nrpages" failed [12/12]
Date: Wed, 07 Mar 2007 14:34:19 +0000 [thread overview]
Message-ID: <1173278059.11001.776.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <1173277501.11001.752.camel@quoit.chygwyn.com>
>From c3f49bc209b28d2b5f82b78baaa827eb3a4d1891 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Wed, 7 Mar 2007 09:06:48 +0000
Subject: [PATCH] [GFS2] Fix bz 229873, alternate test: assertion "!ip->i_inode.i_mapping->nrpages" failed
The following removes an incorrect assertion from the GFS2 glops code. This
fixes Red Hat bz 229873. Thanks to Abhijith Das for testing the patch
and confirming the fix.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Cc: Abhijith Das <adas@redhat.com>
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
index 4221110..39c8ae2 100644
--- a/fs/gfs2/glops.c
+++ b/fs/gfs2/glops.c
@@ -245,7 +245,6 @@ static void inode_go_inval(struct gfs2_glock *gl, int flags)
if (ip && S_ISREG(ip->i_inode.i_mode)) {
truncate_inode_pages(ip->i_inode.i_mapping, 0);
- gfs2_assert_withdraw(GFS2_SB(&ip->i_inode), !ip->i_inode.i_mapping->nrpages);
clear_bit(GIF_PAGED, &ip->i_flags);
}
}
--
1.4.4.2
next prev parent reply other threads:[~2007-03-07 14:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 14:25 [GFS2/DLM] Bug fixes [0/12] Steven Whitehouse
2007-03-07 14:26 ` [GFS2] fix locking mistake [1/12] Steven Whitehouse
2007-03-07 14:27 ` [GFS2] add newline to printk message [2/12] Steven Whitehouse
2007-03-07 14:27 ` [GFS2] NFS filehandle check [3/12] Steven Whitehouse
2007-03-07 14:28 ` [GFS2] fix hangup when multiple processes are trying to write to the same file [4/12] Steven Whitehouse
2007-03-07 14:29 ` [DLM] fs/dlm/user.c should #include "user.h" [5/12] Steven Whitehouse
2007-03-07 14:30 ` [GFS2] pass formal ino in do_filldir_main [6/12] Steven Whitehouse
2007-03-07 14:31 ` [GFS2] Fix bz 230143, incorrect flushing of rgrps [7/12] Steven Whitehouse
2007-03-07 14:31 ` [GFS2] Fix bz 229831, lookup returns wrong inode [8/12] Steven Whitehouse
2007-03-07 14:32 ` [GFS2] Remove unused variable [9/12] Steven Whitehouse
2007-03-07 14:32 ` [GFS2] go_drop_bh is never used, so remove it [10/12] Steven Whitehouse
2007-03-07 14:33 ` [GFS2] build fix [11/12] Steven Whitehouse
2007-03-07 14:34 ` Steven Whitehouse [this message]
2007-03-07 14:43 ` [GFS2/DLM] Pull request Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173278059.11001.776.camel@quoit.chygwyn.com \
--to=swhiteho@redhat.com \
--cc=adas@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®