From: Thomas Gleixner <tglx@linutronix.de>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 6/13] signalfd/timerfd/asyncfd v5 - timerfd core ...
Date: Fri, 16 Mar 2007 08:47:03 +0100 [thread overview]
Message-ID: <1174031223.13341.251.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0703151556290.4998@alien.or.mcafeemobile.com>
On Thu, 2007-03-15 at 16:02 -0700, Davide Libenzi wrote:
> > > + /*
> > > + * When we call this, the initialization must be complete, since
> > > + * aino_getfd() will install the fd.
> > > + */
> > > + error = aino_getfd(&ufd, &inode, &file, "[timerfd]",
> > > + &timerfd_fops, ctx);
> > > + if (error)
> > > + goto err_ctxfree;
> >
> > Again: Please turn this around. No need to start the timer before we
> > know, that everything works.
>
> The timerfd_setup() is not locked, so we need to make sure everything is
> setup, before advertising the fd (and aino_getfd does that).
Right. Did not think about the bad boys peeking at file descriptors :)
tglx
prev parent reply other threads:[~2007-03-16 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 22:19 Davide Libenzi
2007-03-15 21:58 ` Thomas Gleixner
2007-03-15 23:02 ` Davide Libenzi
2007-03-16 7:47 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174031223.13341.251.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®