From: Daniel Walker <dwalker@mvista.com>
To: john stultz <johnstul@us.ibm.com>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] time : SMP friendly alignment of struct clocksource
Date: Tue, 20 Mar 2007 11:04:22 -0700 [thread overview]
Message-ID: <1174413862.3101.185.camel@imap.mvista.com> (raw)
In-Reply-To: <1174413482.17430.1.camel@localhost>
On Tue, 2007-03-20 at 10:58 -0700, john stultz wrote:
> > /* timekeeping specific data, ignore */
> > - cycle_t cycle_last, cycle_interval;
> > - u64 xtime_nsec, xtime_interval;
> > + cycle_t cycle_interval;
> > + u64 xtime_interval;
> > + /*
> > + * Second part is written at each timer interrupt
> > + * Keep it in a different cache line to dirty no
> > + * more than one cache line.
> > + */
> > + cycle_t cycle_last ____cacheline_aligned_in_smp;
> > + u64 xtime_nsec;
> > s64 error;
What was the motivation for having these (cycle_last for example) in the
clocksource structure. I recall them being added in there at one point,
but I'm not sure why.. Specifically the ones that are updated often.
Daniel
next prev parent reply other threads:[~2007-03-20 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 10:09 Eric Dumazet
2007-03-20 17:58 ` john stultz
2007-03-20 18:04 ` Daniel Walker [this message]
2007-03-20 18:38 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174413862.3101.185.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome