From: Rusty Russell <rusty@rustcorp.com.au>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot
Date: Wed, 21 Mar 2007 22:55:53 +1100 [thread overview]
Message-ID: <1174478153.11680.183.camel@localhost.localdomain> (raw)
In-Reply-To: <m1aby7c59k.fsf@ebiederm.dsl.xmission.com>
On Wed, 2007-03-21 at 03:31 -0600, Eric W. Biederman wrote:
> Rusty Russell <rusty@rustcorp.com.au> writes:
> > -/*
> > - * The boot_gdt_table must mirror the equivalent in setup.S and is
> > - * used only for booting.
> > - */
>
> It looks like you are killing a useful comment here for no good reason.
Hi Eric,
I think one has to look harder, then. There is no "equivalent in
setup.S": there is no setup.S, and it's certainly not clear what GDT
this "must mirror": it doesn't mirror any GDT at the moment.
This leaves us with "is only used for booting". The name
"boot_gdt_table" and the code itself are pretty clear.
A comment might well deserve to live here, but not this one 8)
Hope that clarifies,
Rusty.
next prev parent reply other threads:[~2007-03-21 11:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 6:10 [PATCH] Allow per-cpu variables to be page-aligned Rusty Russell
2007-03-21 6:30 ` [PATCH 0/4] i386 GDT cleanups Rusty Russell
2007-03-21 6:32 ` [PATCH 1/4] i386 GDT cleanups: Use per-cpu variables for GDT, PDA Rusty Russell
2007-03-21 6:35 ` [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot Rusty Russell
2007-03-21 6:36 ` [PATCH 3/4] i386 GDT cleanups: clean up cpu_init() Rusty Russell
2007-03-21 6:53 ` [PATCH 4/4] i386 GDT cleanups: cleanup GDT Access Rusty Russell
2007-03-21 9:31 ` [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot Eric W. Biederman
2007-03-21 11:55 ` Rusty Russell [this message]
2007-03-21 16:51 ` Eric W. Biederman
2007-03-21 23:58 ` Rusty Russell
2007-03-22 8:10 ` Sébastien Dugué
2007-03-22 9:24 ` Rusty Russell
2007-03-22 15:59 ` [PATCH] i386 GDT cleanups: Rename boot_gdt_table to boot_gdt Sébastien Dugué
2007-03-23 7:19 ` Rusty Russell
2007-03-23 14:15 ` Andi Kleen
2007-03-21 9:21 ` [PATCH] Allow per-cpu variables to be page-aligned Eric W. Biederman
2007-03-21 11:44 ` Rusty Russell
2007-03-21 16:49 ` Eric W. Biederman
2007-03-22 0:09 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174478153.11680.183.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome